fix: check magic methods on final classes for allow dynamic properties #4285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Sep 4, 2025
calebdw
force-pushed
the
calebdw/push-zvsvrpvwonsx
branch
2 times, most recently
from
961edcc to
a15515c
Compare
ondrejmirtes
requested changes
Sep 4, 2025
There was a problem hiding this comment.
Readonly class can have magic methods (https://3v4l.org/PNmbe) so that check should be moved above $class = $this.
calebdw
force-pushed
the
calebdw/push-zvsvrpvwonsx
branch
from
a15515c to
fda29d4
Compare
|
Good catch, I also added a test for this |
ondrejmirtes
force-pushed
the
calebdw/push-zvsvrpvwonsx
branch
from
fda29d4 to
a8baf69
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This closes phpstan/phpstan#13450
Thanks!